chore: extract icu-messageformat-parser test cases into their own test case files #3763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you hold off merging until I migrate to |
|
sure |
pyrocat101
force-pushed
the
parserTestCase
branch
2 times, most recently
from
ab75aed
to
d5110f7
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
longlho
approved these changes
Sep 6, 2022
longlho
force-pushed
the
parserTestCase
branch
from
d5110f7
to
2b26b36
Compare
longlho
changed the title
unional
pushed a commit
to unional/formatjs
that referenced
this pull request
Jun 7, 2023
…t case files (formatjs#3763) Co-authored-by: long.ho <long.ho@cloudkitchens.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test cases of icu-messageformat-parser are now in
icu-messageformat-parser-testsfolder that can be shared with a potential Rust implementation.To update the mismatching parser result, run the test with
UPDATE_SNAPSHOT=1environment variable.