feat: recontactSessions new option to remind about survey for some time

[KatSick]

What does this PR do?

Add a feature to show survey "reminder" based on displays count. E.g. show survey 3 times and then stop.
Currently it is only possible to show once or until feedback.

How should this be tested?

• Add "Recontact session times". Verify formbricks shows that number of times

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues
• First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

@KatSick is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[mattinannt]

@KatSick Thanks for opening the PR :-) This approach sounds very interesting and I will discuss it with the team :-)
I would do some renaming to make it clearer that the survey will be shown max 5 times per user and also we need to include the check into the getSyncSurveys function, but otherwise it looks good :-)

[KatSick]

thanks @mattinannt. added filtering to getSyncSurveys and fix bug with URL forming. we are using formbricks under reverse-proxy under /formbricks endpoint and if we pass /formbricks to the apiHost property, it lose the /formbricks prefix

[jobenjada]

Hey @KatSick

I have two objections from a UX point of view:

1. Not in every case session === display. So we should make it dependent on the number of displays, not on the number of sessions

2. The UI is consistent with our current selection of Recontact options and would create a bunch of edge cases. I suggest the following:

So I suggest something like this:

What do you think?

Thanks a lot! :)

[jobenjada]

pls see comment above

[KatSick]

looks awesome to me. I will change my implementation.

[jobenjada]

hey @KatSick - any updated from your end? :)

[KatSick]

Working on it. I hope to finish it today/tomorrow

[KatSick]

@jobenjada updated

[KatSick]

I noticed, that current logic is broken for "app" type surveys, since they do not have filterSurveys function anymore... investigating

[KatSick]

I tried my best to fix it, however, I does not work correctly still for app surveys, because it does not always re-fetch config in sync.ts file. If I delete the formbricks-js-app localstorage cache (to force update), it works correctly each time.

how this feature should work without local client state as in survey website type?