New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replaces dnd with dnd-kit #2564
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
Thank you for following the naming conventions for pull request titles! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! :)
Looks good, but I broke it quite quickly:
- Added a new question
- Dragged the open card to the top
dnd-bug.mp4
- Just a small thing but I find it confusing that the the number of the card I grab does not change but its replica changes the number:
dnd-ux.mp4
A solution could be to blur / hide the number of the card you drag? Not sure how the DnD works so open for your suggestion 🤓
Also one E2E test failed previously
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shared a video via Slack. Unfortunately it's not working in my local environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pandeymangg Looks great :-)
Only two small things I noticed while using it:
Can we also make the whole slate area drag-able to make it easier for people to drag and pull instead of only the 9 dots? :-)
Also when we drag a choice we get overlapping borders. Can we give the input a background color to avoid this? :-)
What does this PR do?
Replaces the current library
react-beautiful-dnd
which is used for dnd with @formkit/drag-and-dropFixes # (issue)
How should this be tested?
Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated