feat: Extend Prefilling with an option to auto-skip prefilled values #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
…145-extend-prefilling-with-an-option-to-auto-skip-prefilled-values
…145-extend-prefilling-with-an-option-to-auto-skip-prefilled-values
…lled-values' of https://github.com/formbricks/formbricks into 145-extend-prefilling-with-an-option-to-auto-skip-prefilled-values
pandeymangg
requested changes
May 13, 2024
There was a problem hiding this comment.
Thanks a lot for the PR! @gupta-piyush19 😊
Looks good, just left some comments for minor refactor, pls take a look 🙏
…145-extend-prefilling-with-an-option-to-auto-skip-prefilled-values
…lled-values' of https://github.com/formbricks/formbricks into 145-extend-prefilling-with-an-option-to-auto-skip-prefilled-values
…-skip-prefilled-values
pandeymangg
approved these changes
May 14, 2024
…145-extend-prefilling-with-an-option-to-auto-skip-prefilled-values
…lled-values' of https://github.com/formbricks/formbricks into 145-extend-prefilling-with-an-option-to-auto-skip-prefilled-values
mattinannt
approved these changes
May 23, 2024
There was a problem hiding this comment.
@gupta-piyush19 Nice, the feature works great!! :-) 💪
I only changed the value of skipPrefilling from 1 to true since I noticed we now also use true in all other functionality and this felt more consistent with the other features.
Great job; let's merge this :-)
mattinannt
deleted the
145-extend-prefilling-with-an-option-to-auto-skip-prefilled-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extend Prefilling with an option to auto-skip prefilled values.
Fixes
https://github.com/formbricks/internal/issues/145
How should this be tested?
skipPrefilled=1.Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated