New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multi and single select questions #2606
Conversation
The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌 2 Ignored Deployments
|
Thank you for following the naming conventions for pull request titles! 馃檹 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @pandeymangg, for the changes 馃槉
I've added a few comments 馃檪
Please make the changes accordingly 馃檹
packages/database/data-migrations/20240318050527_add_languages_and_survey_languages/lib/i18n.ts
Outdated
Show resolved
Hide resolved
...itor)/environments/[environmentId]/surveys/[surveyId]/edit/components/SelectQuestionForm.tsx
Outdated
Show resolved
Hide resolved
LGTM 馃殌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pandeymangg thanks for the PR :-) Looks good, the only thing I'm not so happy with is the naming. I would like to keep the term MultipleChoice
instead of Select
since we still have the two different question types multipleChoiceSingle
& multipleChoiceMulti
. Combining them in one form for me the name MultipleChoiceQuestionForm
feels more consistent.
Please make the changes; then we are ready to merge this :-)
What does this PR do?
Makes a common component for the
MultipleChoiceMulti
andMultipleChoiceSingle
select questions calledSelectQuestion
. The types for both the questions types were also almost the same, only the logic had a difference, which is now being solved withzod.refine
Fixes # (issue)
How should this be tested?
Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated