Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multi and single select questions #2606

Merged
merged 4 commits into from May 14, 2024
Merged

Conversation

pandeymangg
Copy link
Contributor

What does this PR do?

Makes a common component for the MultipleChoiceMulti and MultipleChoiceSingle select questions called SelectQuestion. The types for both the questions types were also almost the same, only the logic had a difference, which is now being solved with zod.refine

Fixes # (issue)

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 馃檹

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud 猬滐笍 Ignored (Inspect) Visit Preview May 14, 2024 3:17am
formbricks-docs 猬滐笍 Ignored (Inspect) Visit Preview May 14, 2024 3:17am

Copy link
Contributor

github-actions bot commented May 10, 2024

Thank you for following the naming conventions for pull request titles! 馃檹

Copy link
Contributor

@gupta-piyush19 gupta-piyush19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pandeymangg, for the changes 馃槉
I've added a few comments 馃檪
Please make the changes accordingly 馃檹

@gupta-piyush19
Copy link
Contributor

LGTM 馃殌
Thanks, @pandeymangg 馃檶

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pandeymangg thanks for the PR :-) Looks good, the only thing I'm not so happy with is the naming. I would like to keep the term MultipleChoice instead of Select since we still have the two different question types multipleChoiceSingle & multipleChoiceMulti. Combining them in one form for me the name MultipleChoiceQuestionForm feels more consistent.

Please make the changes; then we are ready to merge this :-)

@mattinannt mattinannt added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 5da9091 May 14, 2024
12 checks passed
@mattinannt mattinannt deleted the fix/select-questions branch May 14, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants