New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry: Support v1.5.0 or greater #1420
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meghfossa
requested review from
jssblck and
csasarak
and removed request for
jssblck
May 1, 2024 20:58
csasarak
requested changes
May 1, 2024
Co-authored-by: Christopher Sasarak <csasarak@users.noreply.github.com>
Co-authored-by: Christopher Sasarak <csasarak@users.noreply.github.com>
csasarak
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds partial support for
dependency groups
.Previously, FOSSA CLI presumed, that when category was not provided, dependency was production dependency. This assumption is incorrect starting with v1.5.0 of poetry. This PR provides partial fix.
Acceptance criteria
Testing plan
I relied on automated tests - but you can perform following.
Place items from https://fossa.atlassian.net/browse/ANE-1281 in sandbox. (with these files you should see 0 deps)
Risks
N/A
References
https://fossa.atlassian.net/browse/ANE-1281
Checklist
docs/
.docs/README.ms
and gave consideration to how discoverable or not my documentation is.Changelog.md
. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top..fossa.yml
orfossa-deps.{json.yml}
, I updateddocs/references/files/*.schema.json
AND I have updated example files used byfossa init
command. You may also need to update these if you have added/removed new dependency type (e.g.pip
) or analysis target type (e.g.poetry
).docs/references/subcommands/<subcommand>.md
.