Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry: Support v1.5.0 or greater #1420

Merged
merged 15 commits into from May 3, 2024
Merged

Conversation

meghfossa
Copy link
Contributor

@meghfossa meghfossa commented Apr 30, 2024

Overview

This PR adds partial support for dependency groups.

Previously, FOSSA CLI presumed, that when category was not provided, dependency was production dependency. This assumption is incorrect starting with v1.5.0 of poetry. This PR provides partial fix.

Acceptance criteria

  • Poetry lock file generated by Poetry v1.5.0 can be accurately analyzed

Testing plan

I relied on automated tests - but you can perform following.

git checkout master && git pull origin && git checkout temp/megh-git-poetry-dev
cabal run fossa -- analyze -o ./sandbox 

Place items from https://fossa.atlassian.net/browse/ANE-1281 in sandbox. (with these files you should see 0 deps)

Risks

N/A

References

https://fossa.atlassian.net/browse/ANE-1281

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@meghfossa meghfossa changed the title Temp/megh git poetry dev Poetry: Support v1.5.0 or greater May 1, 2024
@meghfossa meghfossa marked this pull request as ready for review May 1, 2024 20:58
@meghfossa meghfossa requested a review from a team as a code owner May 1, 2024 20:58
@meghfossa meghfossa requested review from jssblck and csasarak and removed request for jssblck May 1, 2024 20:58
src/Strategy/Python/Poetry.hs Outdated Show resolved Hide resolved
src/Strategy/Python/Poetry.hs Outdated Show resolved Hide resolved
src/Strategy/Python/Poetry/Common.hs Outdated Show resolved Hide resolved
src/Strategy/Python/Poetry/Common.hs Outdated Show resolved Hide resolved
src/Strategy/Python/Poetry/Common.hs Outdated Show resolved Hide resolved
src/Strategy/Python/Poetry/PyProject.hs Show resolved Hide resolved
meghfossa and others added 4 commits May 1, 2024 16:00
Co-authored-by: Christopher Sasarak <csasarak@users.noreply.github.com>
Co-authored-by: Christopher Sasarak <csasarak@users.noreply.github.com>
@meghfossa meghfossa requested a review from csasarak May 1, 2024 22:15
@meghfossa meghfossa enabled auto-merge (squash) May 3, 2024 22:00
@meghfossa meghfossa merged commit 759be18 into master May 3, 2024
16 checks passed
@meghfossa meghfossa deleted the temp/megh-git-poetry-dev branch May 3, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants