Additional proposal questions on the proposal form #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks could you add a screenshot, please? |
|
|
mariobehling
changed the title
mariobehling
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13
this is still work in progress for testing only.
proposal questions are now shown at the bottom of the proposal form.
speaker/profile question are shown in the profile form above the availability question (because the availability is such a huge box that i felt a one line question below it might be skipped)
the question form has been disabled (but no code removed), which breaks several tests in tests/cfp/views/test_cfp_wizard.py
two different methods have been used to import the questions into the forms. this is intentional. while the second method (used on the profile form) is simpler, it may not allow reordering questions later. so i want to try both to see which one will be better later.