Run lintian on Debian packages #1845
Conversation
There was a problem hiding this comment.
-
make build-debspasses locally
Failed with source-is-missing until I deleted:
./client/htmlcov/; and./target/.
We can't realistically enforce make clean before a local make build-debs. Can we further ignore these transient paths that are generated by other tools?
-
DEBIAN_VERSION=bookworm make build-debspasses locally too -
FAST=1 make build-debsdoesn't run lintian - CI passes
- Infra moving the "Required" label from the now-renamed build-debs2/bullseye job to lintian/bullseye.
I will coordinate this in #infrastructure after approval and before merge.
Yes, we can exclude those two paths from the package itself (ideally we'd just do something like |
legoktm
force-pushed
the
lintian
branch
2 times, most recently
from
d0dadb6
to
9c4671f
Compare
lintian is the Debian package linter and catches a number of things we can improve in our packages. For now I've suppressed everything and annotated them with TODO/FIXME for others to take on or address incrementally. lintian is run at the end of `make build-debs` unless the "FAST" environment variable is set. Any warning or error causes the build to fail, but it can be suppressed in the corresponding lintian-overrides file. A number of file and directories that may exist in the tree are excluded from the package build process through d/source/options to prevent lintian from seeing them. Internally there's a bit of work so we can identify the *.changes file that we just built, so we first build into a temporary directory, copy the files into our repository's build, then run lintian in the temporary directory. Refs #1785.
|
OK, files have now been excluded via d/source/options. I also rebased because some new things in the export package needed suppression. |
Status
Ready for review
Description
lintian is the Debian package linter and catches a number of things we can improve in our packages. For now I've suppressed everything and annotated them with TODO/FIXME for others to take on or address incrementally.
lintian is run at the end of
make build-debsunless the "FAST" environment variable is set. Any warning or error causes the build to fail, but it can be suppressed in the corresponding lintian-overrides file.Internally there's a bit of work so we can identify the *.changes file that we just built, so we first build into a temporary directory, copy the files into our repository's build, then run lintian in the temporary directory.
Refs #1785.
Test Plan
make build-debspasses locallyDEBIAN_VERSION=bookworm make build-debspasses locally tooFAST=1 make build-debsdoesn't run lintian