Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NUC 7 and 8 recommendation, remove Intel references, and update links #540

Merged
merged 1 commit into from Mar 25, 2024

Conversation

nathandyer
Copy link
Contributor

Status

Ready for review

Description of Changes

  • Description:

This PR removes NUC 7 (which has already reached EOL) and NUC 8 (which reaches EOL next month) from our list of recommended NUC models.

It also addresses changes as a result of Intel's decision to discontinue manufacturing NUCs, and reflects ASUS taking over the NUC line. For NUC 11 and 12, links are provided for the ASUS page. For NUC 10, which ASUS does not list, a simplynuc link is provided instead.

It also removes references to Intel, where necessary.

Testing

  • Visual inspection
  • CI passes

Release

  • Can be tagged in a stable release when merged

Checklist (Optional)

  • Doc linting (make docs-lint) passed locally
  • Doc link linting (make docs-linkcheck) passed
  • You have previewed (make docs) docs at http://localhost:8000

Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested, we shouldn't wait for the PR creator to be available for them tho :)

docs/admin/installation/hardware.rst Show resolved Hide resolved
@@ -534,56 +534,6 @@ startup and adjust the system configuration:

.. |NUC10 leads| image:: ../../images/hardware/nuc10_leads.jpg

.. _nuc8_recommendation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be language here to flag that these are EOL. Straight-up removing them from the docs is liable to cause confusion for folks still using them and looking for guidance.

For example "We previously recommended the name. As it has reached EOL, we recommend replacing it with a model which still has vendor support. Compatibility testing for the grsec kernel will continue for the next N server releases" (where N is a number we argue about)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed it to be along these lines, but instead of promising an explicit sunset timeline, I've said it'll likely work but we're going to stop explicitly testing on it.

docs/admin/installation/hardware.rst Outdated Show resolved Hide resolved
…e links

This commit removes NUC 7 (which has already reached EOL) and NUC 8
(which reaches EOL next month) from our list of recommended NUC models.

It also addresses changes as a result of Intel's decision to discontinue
manufacturing NUCs, and reflects ASUS taking over the NUC line. For
NUC 11 and 12, links are provided for the ASUS page. For NUC 10, which
ASUS does not list, a simplynuc link is provided instead.

This commit also removes references to Intel, where necessary.
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on visual review.

@zenmonkeykstop zenmonkeykstop added this pull request to the merge queue Mar 25, 2024
Merged via the queue into main with commit 892bd53 Mar 25, 2024
4 checks passed
@zenmonkeykstop zenmonkeykstop deleted the nucs-transition branch March 25, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ark.intel.com NUC links are 404s
3 participants