Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding version 2 of the SDW CI scripts #40

Merged
merged 17 commits into from Mar 13, 2024
Merged

Adding version 2 of the SDW CI scripts #40

merged 17 commits into from Mar 13, 2024

Conversation

mig5
Copy link
Contributor

@mig5 mig5 commented Mar 1, 2024

Closes #39

Works towards https://github.com/freedomofpress/infrastructure/issues/4603

Relates to https://github.com/freedomofpress/infrastructure/pull/4659

This is all the code currently in use on the new version of the CI.

The docs are updated, but I am yet to do a new diagram.

@mig5 mig5 force-pushed the v2 branch 6 times, most recently from 8bdecaa to 4611ddc Compare March 4, 2024 02:47
@mig5 mig5 requested a review from eloquence March 4, 2024 04:16
@mig5 mig5 mentioned this pull request Mar 4, 2024
Copy link
Member

@eloquence eloquence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per infra team meeting, took a quick spin through the docs portion only. Since I've not performed a code review, not submitting a formal +1, but docs look good with a couple of comments/questions.

INSTALL.md Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@mig5
Copy link
Contributor Author

mig5 commented Mar 8, 2024

There is some bug with my automatic update + snapshot logic that runs nightly. It is not iterating over both VMs for the same version, it's updating the first machine but not the second. I'll look into it.

@mig5
Copy link
Contributor Author

mig5 commented Mar 12, 2024

Finally fixed what was indeed a bug in the nightly self-update/snapshot system, affecting the 'second' VM for whatever version.

I feel like this PR could be merged now, though of course, no-one's reviewed the code.. who wants to do that? Someone who was familiar with the original flow?

From a 'how does the build/test work' perspective, it's more or less the same as it ever was with the runner.py (which is merely simplified now to have no teardown logic). The rest of the 'new' stuff is mostly the run.py which runs on the bastion to restore/power up VMs to perform that runner.py in the dom0 once booted.

Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small review since you asked for one :)

INSTALL.md Outdated Show resolved Hide resolved
sd-dev/bin/begin.py Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
@mig5
Copy link
Contributor Author

mig5 commented Mar 13, 2024

The sd-dev VM is now Debian (11 on Qubes 4.1, 12 on Qubes 4.2) with podman instead of docker.

The config/sd-journalist files are now copied from the cloned repo, in sd-dev, rather than downloaded.

I also added Slack notifications, just for if the CI fails (not sending notifications on success, to avoid alert fatigue).

I think we should be ok to merge this in now (as discussed in infra sync, I'll probably self-merge, but I'll wait another 12 hours or so in case Kunal spots any other issues).

@mig5 mig5 mentioned this pull request Mar 13, 2024
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much for working on this :)

@mig5 mig5 merged commit 54d872b into main Mar 13, 2024
@mig5 mig5 deleted the v2 branch March 13, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nightlies
3 participants