Skip to content

Commit

Permalink
Truncate isolate_level to FRIBIDI_BIDI_MAX_EXPLICIT_LEVEL
Browse files Browse the repository at this point in the history
  • Loading branch information
@dov
dov committed Oct 24, 2019
1 parent deb5884 commit 034c6e9
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion lib/fribidi-bidi.c
View file
Expand Up @@ -747,7 +747,9 @@ fribidi_get_par_embedding_levels_ex (
}

RL_LEVEL (pp) = level;
RL_ISOLATE_LEVEL (pp) = isolate_level++;
RL_ISOLATE_LEVEL (pp) = isolate_level;
if (isolate_level < FRIBIDI_BIDI_MAX_EXPLICIT_LEVEL-1)
isolate_level++;
base_level_per_iso_level[isolate_level] = new_level;

if (!FRIBIDI_IS_NEUTRAL (override))
Expand Down

3 comments on commit 034c6e9

@kloczek
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any plans to make new release?

This seems is like or actually is CVE.

@dov
Copy link
Contributor Author

@dov dov commented on 034c6e9 Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I actually deprecated the whole base_level_per_iso_level which wasn't even needed for the algo.

@kloczek
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx :)

Please sign in to comment.