Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] letsencrypt: add post issue/renewal hook possibility #822

Closed
snoopotic opened this issue Mar 29, 2020 · 3 comments
Closed
Assignees
Projects
Milestone

Comments

@snoopotic
Copy link

Requesting a feature to add a possibility to run scripts/code/commands after a letsencrypt issue/renewal was running.

At least pointing to a shell script (file) should be enough.

Background:
As acme.sh runs as root by the froxlor cron, all certificates and keys are owned by root and filemode is 0600. If you maybe manually changed owner or filemode of the certs - each run of acme.sh resets owner and filemode. This is by design of acme.sh and for security reasons the right way.

Adding the requested feature could make it possible to allow further usage of the certificates.
Advanced system engineers could copy the/certain files and make necessary recurring changes needed after every renewal/issue.

Usecase:

On my Hosts I run different daemons. Some are not running as root but also need ssl-certificates. non-root daemons/users cannot access the certificate files stored by scme.sh.
Thus I currently manually copy and chown the needed certs after they renewed. This would be nice to happen automatically.

Sadly, also acme.sh does not provide a similar posthook - and even if - currently you could not use it in froxlor.

@d00p
Copy link
Member

d00p commented Mar 29, 2020

I also have thought about that yes. For mail-services a renew needs to trigger a restart of the services in order for them to use the updated certificate. I hopefully find the time to add such a feature in the near future.

If you want/need to do something with the certificates already existing created via froxlor, you can easily access them via a script or anything from froxlor's database or even the generated files which are used in the webserver-vhost-configs

@d00p d00p self-assigned this Mar 29, 2020
@d00p d00p added this to To do in 0.10.x via automation Mar 29, 2020
FliegenKLATSCH added a commit to FliegenKLATSCH/Froxlor that referenced this issue Apr 18, 2022
FliegenKLATSCH added a commit to FliegenKLATSCH/Froxlor that referenced this issue Apr 18, 2022
@d00p d00p added this to the 2.2.x milestone Jan 14, 2024
@d00p
Copy link
Member

d00p commented Jan 14, 2024

Implementation of a renew-hook started with 8740947 for future version 2.2

@d00p
Copy link
Member

d00p commented Jan 21, 2024

will be tracked in #1186

@d00p d00p closed this as completed Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
0.10.x
  
To do
Development

Successfully merging a pull request may close this issue.

2 participants