Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global acme reload command (#822) #1028

Closed
wants to merge 1 commit into from

Conversation

FliegenKLATSCH
Copy link
Contributor

@FliegenKLATSCH FliegenKLATSCH commented Apr 18, 2022

Description

Add a setting to pass the --reloadcmd to acme.sh

Fixes #822

Type of change

  • New feature (non-breaking change which adds functionality)

@d00p
Copy link
Member

d00p commented Nov 5, 2022

Shouldn't that be domain-specific not globally? In your example, dovecot and postfix would get restarted for EVERY certificate renew of every domain

@snoopotic
Copy link

Yeah, I also reuse one of my LE certificates for the mailserver.
Maybe there can be a setting: "used for Mailserver" and only if this cert gets renewed, mailserver services get restarted.

@d00p
Copy link
Member

d00p commented Nov 5, 2022

pretty specific that way...what if i have some other services running with one of my froxlor-administrated domains and wanted to reload these after renew?
But dangerous, as i would NEVER allow a customer to enter a reload command to be run on the server after certificate renew.

@FliegenKLATSCH
Copy link
Contributor Author

FliegenKLATSCH commented Dec 24, 2022

I agree, this setting should not be visible to any customer. Are those serversettings visible to them?
The proposed description says that it is executed for each certificate. For me that's fine, the reload doesn't hurt and I don't have that many domains..
If someone wants to restrict this, it could be possible with [ "${Le_Domain}" = "example.com" ] && systemctl reload postfix.service in that setting (see https://github.com/acmesh-official/acme.sh/blob/master/acme.sh#L5867)

@d00p d00p deleted the branch froxlor:0.10.x October 29, 2023 10:00
@d00p d00p closed this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] letsencrypt: add post issue/renewal hook possibility
3 participants