Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database lastedit not updating when changing loadout/team #2072

Closed
frzyc opened this issue May 5, 2024 · 2 comments · Fixed by #2142
Closed

database lastedit not updating when changing loadout/team #2072

frzyc opened this issue May 5, 2024 · 2 comments · Fixed by #2142
Labels
good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR

Comments

@frzyc
Copy link
Owner

frzyc commented May 5, 2024

When the loadouts are changed/updated, it doesn't change the lastEdit time listed under the database.

Originally posted by @maoadrian12 in #2070 (comment)

Issue like originates from https://github.com/frzyc/genshin-optimizer/blob/master/libs/gi/db/src/Database/ArtCharDatabase.ts#L86, where database needs to followAny changes to teams, builds, teamChars

@frzyc frzyc added the good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR label May 5, 2024
@CordonZeus22
Copy link
Contributor

Any changes to DataManagers or DataEntries should change the lastEdit or only the one you listed ?

@frzyc
Copy link
Owner Author

frzyc commented May 15, 2024

other than dbmeta(where last edit is stored), that may cause an infinite loop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue with low complexity and relatively easy solution for those looking to raise an easy PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants