Tallies added for teams and loadouts

[maoadrian12]

Describe your changes

Added a tally when looking at databases for the number of teams and loadouts.

Issue or discord link

#2040

Testing/validation

BEFORE

AFTER

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

• [ x ] I have commented my code in hard-to understand areas.
• [ ] I have made corresponding changes to README or wiki.
• [ ] For front-end changes, I have updated the corresponding English translations.
• [ x ] I have run yarn run mini-ci locally to validate format and lint.
• [ x ] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

[github-actions]

[frontend] [Sun May 5 02:51:20 UTC 2024] - Deployed 22c30a9 to https://genshin-optimizer-prs.github.io/pr/2070/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sun May 5 16:27:34 UTC 2024] - Deployed 1beb311 to https://genshin-optimizer-prs.github.io/pr/2070/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Mon May 6 16:44:23 UTC 2024] - Deployed 004ed14 to https://genshin-optimizer-prs.github.io/pr/2070/frontend (Takes 3-5 minutes after this completes to be available)

[Mon May 6 16:52:45 UTC 2024] - Deleted deployment

[frzyc]

Is it possible to move the last edit time here? Will balance out the whitespace.
Also, update translations in https://github.com/frzyc/genshin-optimizer/blob/master/libs/gi/localization/assets/locales/en/settings.json

[maoadrian12]

Looks like this now:

Not sure if this is intended behavior or not, but when the loadouts are changed/updated, it doesn't change the lastEdit time listed under the database.

[frzyc]

Looks like this now: Not sure if this is intended behavior or not, but when the loadouts are changed/updated, it doesn't change the lastEdit time listed under the database.

Looks much better now. That is a good catch on the lastEdit issue: #2072

[frzyc]

Need to pass format CI stage:
assuming you are running a fork with upstream set to the main repo, you can run nx format write --base upstream/master. Next time, it might be better to create a feature branch in your fork to avoid this issue.

[frzyc]

The number of loadouts should just be database.teamChars.values.length.

Can you also include the number of builds?
database.builds.values.length

[maoadrian12]

Need to pass format CI stage: assuming you are running a fork with upstream set to the main repo, you can run nx format write --base upstream/master. Next time, it might be better to create a feature branch in your fork to avoid this issue.

How should I know if the formatting is correct, when I run the command(yarn run nx format:check) I get a lot of CRLF warnings, is that fine?
Besides that, here's what the screen looks like now:

[frzyc]

I get a lot of CRLF warnings, is that fine?

I think you need to change your autocrlf settings in git:

git config core.autocrlf false

[maoadrian12]

When I do yarn run mini-ci, I only fail the gi-dm-localization test because the file at libs/gi/dm/GenshinData/TextMap/TextMapCHS.json isn't found, is this fine?

[frzyc]

That missing file is likely due to the datamine submodule not being loaded, you can run reload-dm for that. For the format issue, you can follow the instructions here #2070 (review). (mini-ci is suppose to run format, but it won't work for you here because you are working off your fork's master)

[maoadrian12]

Did I break something? The checks have been going on for a while

[frzyc]

Did I break something? The checks have been going on for a while

Nope, because you are a first contributor, the pipeline needs approval before running. I've started it.

[frzyc]

LGTM, thanks for your work!.