Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for extended colors (xterm 256 and 24 bit rgb) #72

Merged
merged 1 commit into from
Mar 14, 2017

Conversation

JoeMerten
Copy link

@JoeMerten JoeMerten commented Mar 4, 2017

This PR adds support for extended color like esc[38;5;<index>m or esc[38;2;<r>;<g>;<b>m when parsing.
Need this to implement extended color support in jenkins-ansicolor-plugin. See also #89 and #96.

extended color like `esc[38;5;<index>m` or `esc[38;2;<r>;<g>;<b>m`
@ssbarnea
Copy link

ssbarnea commented Mar 14, 2017

@gnodet Can we have this reviewed and merged? Seem to be needed for the new release of jenkins-ansicolor.

@gnodet gnodet merged commit 471902d into fusesource:master Mar 14, 2017
@ssbarnea
Copy link

@gnodet Thank you! I performed a new build of jenkins-ansicolor-plugin and tested it and I can confirm that this patch fixed it. Now we only need 1.15 to be released so we can officially consume it.

@ssbarnea
Copy link

@gnodet or @hboutemy Can we have a 1.15 released? I cannot make an official build that uses a git branch of jansi. I did this for testing, worked really well, time to get 1.15 jar uploaded to maven.

@hboutemy
Copy link
Collaborator

before releasing JAnsi 1.15, I'd like to enhance HawtJNI first: https://issues.apache.org/jira/browse/MNG-6186
I'll provide a PR soon

@JoeMerten JoeMerten deleted the ExtColors branch March 17, 2017 15:17
@gnodet
Copy link
Member

gnodet commented Mar 17, 2017

Sorry, I missed your latest comment. Jansi 1.15 has been released, but let me know in case you need a new release.

@hboutemy
Copy link
Collaborator

releases are cheap: no big issue, better to have a release now than a promise to do it later
I'll keep you informed
notice: you don't seem to track milestones with GitHub issue tracker, is it intended? It would be easy and useful to track what goes into each release

@hboutemy
Copy link
Collaborator

fusesource/hawtjni#35 created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants