-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for xterm 256 colors and 24 bit colors #96
Conversation
Conflicts: CHANGELOG.md
@@ -88,7 +88,7 @@ | |||
<dependency> | |||
<groupId>org.fusesource.jansi</groupId> | |||
<artifactId>jansi</artifactId> | |||
<version>1.12</version> | |||
<version>1.14-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to ship with an unshipped version of 1.14. I am not saying we shouldn't merge this, but we should be careful releasing with this.
... and this doesn't pass build since the SNAPSHOT version is a private one. |
Thanks Joe! Maybe release what's on master though? It fixes a number of issues. |
In #95, you commented:
Could you help me to understand the idea behind this approch? |
I mean checking out the source of Jansi as a git submodule, then bulk replacing the namespace by something internal during the build and using that code. |
Embedded jansi's AnsiOutputStream.java into our source tree to avoid version bumping. See also jenkinsci#95 and jenkinsci#96.
I'm a bit aware about git submodule because of trouble in the past (but however, I'm not git expert at all). |
I like it enough. Party on. |
This PR adds support for
esc[38;…m
/esc[48;…m
for 256 colors and 24 bit foreground / background colors. See also:Please note, that this needs jansi PR #72 to build & work. I'd increased the jansi version dependency in the
pom.xml
to1.14-SNAPSHOT
to build locally.Further, we run into a version bump as described in #95 which leads also to make 256 colors and 24 bit colors don't work (even if we have successfully build and all plugin tests passed).
As I found a way to got it work with Jenkins 1.653 (by just deleting jansi-1.9.jar), I'd found no way to make it work with Jenkins 2.x. As dblock commented in #95, we might have to wait until even the Jenkins guys will pick up the latest jansi changes.