Implement Phase2 HLT Taus and L1HPSTaus #16

sandeepbhowmik1 · 2021-05-10T22:09:14Z

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

…gger studies to dedicated branch

cms-tau-pog/TauMLTools#24 configurable via python config

This configuration is based on - the Tracking v6.1 baseline configuration - the TICL v3 configuration

The b-tagging paths should be consistent with the Jets/MET configuration.

Remove unused sequences and modules: - BProbability for Puppi and PF jets, and their corresponding submodules; - HLTObjects and L1Objects; - DeepCSV and DeepJet paths for PFCHS jets, and their corresponding submodules. Merge all noFilter paths into MC_BTV. Various renames: - remove _v1 tags from path names; - rename L1T filters to match the implementation; - rename hltDoublePFPuppiJets128Eta2p3MaxDeta1p6_cfi to hltDoublePFPuppiJets128Eta2p4MaxDeta1p6_cfi because of wrong eta cut in name.

At the same time: - remove unused PSets and modules - clean up whitespcaes - clean up the imports in the main configuration file

…oducer)

fwyzard · 2021-05-11T22:06:09Z

HLTrigger/Phase2HLTPFTaus/plugins/PFRecoTauChargedHadronQualityPluginHGCalWorkaround.cc

@@ -0,0 +1,27 @@
+#include "HLTrigger/Phase2HLTPFTaus/plugins/PFRecoTauChargedHadronQualityPluginHGCalWorkaround.h"


Maybe this plugin should go into RecoTauTag/RecoTau/ ?

fwyzard · 2021-05-11T22:07:09Z

HLTrigger/Phase2HLTPFTaus/plugins/PFTauPairProducer.cc

@@ -0,0 +1,108 @@
+#include "HLTrigger/Phase2HLTPFTaus/plugins/PFTauPairProducer.h"


Maybe this plugin should go under RecoTauTag/HLTProducers/ ?

fwyzard · 2021-05-11T22:07:49Z

HLTrigger/Phase2HLTPFTaus/plugins/PFTauPairProducer.h

@@ -0,0 +1,45 @@
+#ifndef HLTrigger_Phase2HLTPFTaus_PFTauPairProducer_h


Can you merge the class declaration into the .cc file ?

fwyzard · 2021-05-11T22:09:18Z

HLTrigger/Phase2HLTPFTaus/plugins/PFTauPairProducer.cc

+PFTauPairProducer::~PFTauPairProducer()
+{}


Move to the class declaration as ~PFTauPairProducer() = default;

fwyzard · 2021-05-11T22:10:22Z

HLTrigger/Phase2HLTPFTaus/plugins/PFTauPairProducer.cc

+
+void PFTauPairProducer::produce(edm::Event& evt, const edm::EventSetup& es)
+{
+  std::unique_ptr<reco::PFTauPairCollection> pfTauPairs(new reco::PFTauPairCollection());


Suggested change

std::unique_ptr<reco::PFTauPairCollection> pfTauPairs(new reco::PFTauPairCollection());

auto pfTauPairs = std::make_unique<reco::PFTauPairCollection>();

fwyzard · 2021-05-11T22:11:37Z

HLTrigger/Phase2HLTPFTaus/plugins/RecoTauCleanerPluginHGCalWorkaround.h

+{
+ public:
+  explicit RecoTauCleanerPluginHGCalWorkaround(const edm::ParameterSet& cfg, edm::ConsumesCollector&& cc);
+  ~RecoTauCleanerPluginHGCalWorkaround() override {}


Suggested change

~RecoTauCleanerPluginHGCalWorkaround() override {}

~RecoTauCleanerPluginHGCalWorkaround() override = default;

fwyzard · 2021-05-11T22:14:30Z

Some more general comments:

please reformat all files with scram b code-format
please consider using existing packages instead of creating new ones

sandeepbhowmik1 · 2021-05-16T15:52:07Z

Dear Andrea,

I have modified all the code considering your all comments.

There were merge conflict with some files in
RecoTauTag/RecoTau

RecoTauTag/RecoTau/interface/DeepTauBase.h
RecoTauTag/RecoTau/plugins/DeepTauId.cc
RecoTauTag/RecoTau/plugins/PFRecoTauDiscriminationByIsolation.cc
RecoTauTag/RecoTau/src/DeepTauBase.cc

I have kept these from default i.e. which are in CMSSW_11_1_8

and I have renamed the new files updated by Christian

RecoTauTag/RecoTau/interface/DeepTauBaseForHLT.h
RecoTauTag/RecoTau/plugins/DeepTauIdForHLT.cc
RecoTauTag/RecoTau/plugins/PFRecoTauDiscriminationByIsolationForHLT.cc
RecoTauTag/RecoTau/src/DeepTauBaseForHLT.cc

fwyzard · 2021-05-16T16:09:04Z

Hi Sandeep, yes, those are the conflicts I was talking about earlier. I don't think having two different versions of the same modules of a good idea. Can you work with Christian to update the HLT set up to use the version in the release ? Or, if anything is missing in the code, to update it accordingly ? Thank you, .Andrea

sandeepbhowmik1 · 2021-05-16T17:37:05Z

ok I will talk to Christian about it.

sandeepbhowmik1 · 2021-06-15T13:52:24Z

The present code can reproduce the HLT TDR results but still there are 2 technical issues to solve.
I have uploaded this to share and discuss with the experts.
So if anyone wants to use this code now please let me know.
Thanks

sandeepbhowmik1 · 2021-06-18T16:13:57Z

So those 2 technical issues are also solved now

update master

veelken and others added 30 commits August 27, 2020 10:59

pushed all changes to tau reconstruction code for Phase-2 HLT tau tri…

a747a23

…gger studies to dedicated branch

made handling of hcalFraction issue

3094f04

cms-tau-pog/TauMLTools#24 configurable via python config

improved format of JSON file used for debugging DeepTau input variables

7198164

Add the baseline Phase 2 HLT configuration for Jets/MET

ee70cbc

This configuration is based on - the Tracking v6.1 baseline configuration - the TICL v3 configuration

Add the baseline Phase 2 HLT configuration for b-tagging

e7dc11a

The b-tagging paths should be consistent with the Jets/MET configuration.

Update the list of collections kept from the previous steps

f9750f9

Update global tag to 111X_mcRun4_realistic_T15_v5

ebb7fae

Update options

f56ad60

Drop unused modules

2345646

Replace PFPuppiMET with PFPuppiMETTypeOne

a5c4f63

Update the process name referenced in the modules

697141f

Update the configuration for CMSSW 11.1.8

5a010b0

Regenerate the full configuration dump

0a0edae

Update the configuration for the DeepFlavour model

3b83cb2

Update the Jets/MET thresholds to match the AR and draft TDR

09a7184

Update MessageLogger configuration

da782c4

Update DQMStore configuration

a8cb8ee

Add the FastTimerService

381abc2

Clean up whitespace

515aa1d

Remove the definition of the EventContents from the HLT menu

40cb679

Rename ESPrefer modules for consistency

c77fe69

Remove the PF CHS reconstruction

15fdf12

Suppress the warnings from hltDeepInclusiveVertexFinderPF

5c13ef9

Update the fully expanded configuration

30bb589

Integrate muons in the Phase 2 HLT menu

020deef

At the same time: - remove unused PSets and modules - clean up whitespcaes - clean up the imports in the main configuration file

Fix plugin name in Jet/MET reco (HLTSiPixelClusterMultiplicityValuePr…

7143404

…oducer)

Fix the "No newline at end of file" warnings

a585156

Fix the HGCAL and CSC geometry used by the trigger simulation

9dd1d6c

Add the HLTBeginSequence and HLTEndSequence to all trigger paths

05fd3f5

fwyzard reviewed May 11, 2021

View reviewed changes

Modified all the code considering all the comments by Andrea

7d2750e

uploaded code for DeepTauDiscriminator

c767fe9

modified the config to run in one go

aa7410d

fwyzard force-pushed the HLT_Phase2_menu branch 13 times, most recently from 4e6142d to 205db68 Compare September 21, 2021 14:09

fwyzard pushed a commit that referenced this pull request Apr 26, 2022

Merge pull request #16 from cms-sw/master

43ac400

update master

fwyzard closed this May 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Phase2 HLT Taus and L1HPSTaus #16

Implement Phase2 HLT Taus and L1HPSTaus #16

sandeepbhowmik1 commented May 10, 2021

fwyzard May 11, 2021

fwyzard May 11, 2021

fwyzard May 11, 2021

fwyzard May 11, 2021

fwyzard May 11, 2021

fwyzard May 11, 2021

fwyzard commented May 11, 2021

sandeepbhowmik1 commented May 16, 2021

fwyzard commented May 16, 2021 via email

sandeepbhowmik1 commented May 16, 2021

sandeepbhowmik1 commented Jun 15, 2021

sandeepbhowmik1 commented Jun 18, 2021

		@@ -0,0 +1,27 @@
		#include "HLTrigger/Phase2HLTPFTaus/plugins/PFRecoTauChargedHadronQualityPluginHGCalWorkaround.h"

		@@ -0,0 +1,108 @@
		#include "HLTrigger/Phase2HLTPFTaus/plugins/PFTauPairProducer.h"

		@@ -0,0 +1,45 @@
		#ifndef HLTrigger_Phase2HLTPFTaus_PFTauPairProducer_h

	std::unique_ptr<reco::PFTauPairCollection> pfTauPairs(new reco::PFTauPairCollection());
	auto pfTauPairs = std::make_unique<reco::PFTauPairCollection>();

	~RecoTauCleanerPluginHGCalWorkaround() override {}
	~RecoTauCleanerPluginHGCalWorkaround() override = default;

		PFTauPairProducer::~PFTauPairProducer()
		{}

Implement Phase2 HLT Taus and L1HPSTaus #16

Implement Phase2 HLT Taus and L1HPSTaus #16

Conversation

sandeepbhowmik1 commented May 10, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

fwyzard May 11, 2021

Choose a reason for hiding this comment

fwyzard May 11, 2021

Choose a reason for hiding this comment

fwyzard May 11, 2021

Choose a reason for hiding this comment

fwyzard May 11, 2021

Choose a reason for hiding this comment

fwyzard May 11, 2021

Choose a reason for hiding this comment

fwyzard May 11, 2021

Choose a reason for hiding this comment

fwyzard commented May 11, 2021

sandeepbhowmik1 commented May 16, 2021

fwyzard commented May 16, 2021 via email

sandeepbhowmik1 commented May 16, 2021

sandeepbhowmik1 commented Jun 15, 2021

sandeepbhowmik1 commented Jun 18, 2021