Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure absolute URL for initConfig.baseurl + remove initConfig.group property #836

Merged
merged 10 commits into from
May 6, 2024

Conversation

Raruto
Copy link
Contributor

@Raruto Raruto commented May 3, 2024

Motivation

  1. allow JS developers to easily use: new URL(path, initConfig.baseurl) to construct absolute URLs (ref: client/#617)
  2. remove unclear/unnecessary reference to admin "group" data structure for client-side config (ref: initConfig.groupinitConfig, closes: #372)

@Raruto Raruto added the refactoring Anything which could result in a API change label May 3, 2024
@Raruto Raruto added this to the v3.8 milestone May 3, 2024
@Raruto Raruto requested a review from volterra79 May 3, 2024 13:42
@Raruto Raruto changed the title Ensure absolute for initConfig.baseurl + remove initConfig.group property Ensure absolute URL for initConfig.baseurl + remove initConfig.group property May 3, 2024
@Raruto Raruto merged commit 77bc543 into dev May 6, 2024
4 checks passed
@Raruto Raruto deleted the absolute-baseurl branch May 6, 2024 14:19
@Raruto Raruto mentioned this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Anything which could result in a API change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move plugins configuration from initConfig to project config
1 participant