Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerized development #29

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Dockerized development #29

wants to merge 1 commit into from

Conversation

Raruto
Copy link
Collaborator

@Raruto Raruto commented Jun 6, 2022

For greater clarity I took what is needed to develop this library via docker directly from here: g3w-suite/g3w-suite-docker@8810468 * and moved it within this repository inside the docker folder.

There are also other non-strictly related changes (some code refactoring), but before I go too far I send it as a draft so you can check if it's good enough already (or notify me of incorrect changes).

Closes: #26

* as @wlorenzetti knows actually that script works but does not create the default user and some other fixtures

Raruto

@wlorenzetti
Copy link
Member

Hi @Raruto it could be a clear solution, but I'm afraid it might become difficult to keep too many dockerization schema. I think it is best to discuss this in a call :).

For the discussion of creating users and loading fixtures, I push a fix for it: g3w-suite/g3w-admin@fb45e5d. Please try the procedure again clearing before every docker volume and directories and let me know if you have any problems.

@Raruto
Copy link
Collaborator Author

Raruto commented Jun 6, 2022

Please try the procedure again clearing before every docker volume and directories and let me know if you have any problems.

I did some tests from scratch and now the database part seems to work, now I have some problem with the contents of the project_data folder (which is apparently empty for windows explorer) but for the moment nothing to worry about.

I'm afraid it might become difficult to keep too many dockerization schema.

I was hoping that those files wouldn't change so much often, but as you see, nothing definitive 😉

Raruto

@wlorenzetti
Copy link
Member

@Raruto project_data is empty by default, so I think now is ok? For dockerization into client code, ok for me ask to @volterra79 .

@Raruto
Copy link
Collaborator Author

Raruto commented Jun 7, 2022

project_data is empty by default

Yes, I meant that on the wsl2 side I don't see its content even if you upload something through the g3w-suite uploader.
Thinking about it I would say it is correct, since this is not a shared folder it should not be visible directly from Windows explorer, in fact through docker exec I can list all that files correctly.

To understand, also on the wsl2 side I can see the folder \tmp\shared-volume-g3wsuite-dev\project_data (which is always empty) but I think this behavior is more related to the functioning of docker on Windows.

For dockerization into client code, ok for me ask to @volterra79

Ok, thank you.

Raruto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make use of engines property inside package.json
3 participants