Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor response parsers (aka. MIME Types) #541

Draft
wants to merge 26 commits into
base: dev
Choose a base branch
from
Draft

Refactor response parsers (aka. MIME Types) #541

wants to merge 26 commits into from

Conversation

Raruto
Copy link
Collaborator

@Raruto Raruto commented Jan 11, 2024 •
edited

This PR is a continuation of #77 and #508.

Sample project: gml-layers.qgs

List of changes

Pretty complete rewrite of this file: src/utils/parsers/index.js:

  • consolidate all parsing logic into a single static function: ResponseParser.get
  • extract some other utility functions to prevent circular imports:
    • utils/sanitizeFidFeature.js
    • utils/reverseGeometry.js
    • utils/removeZValueToOLFeatureGeometry.js
    • utils/is3DGeometry.js
    • utils/groupBy.js
    • utils/addZValueToOLFeatureGeometry.js

@Raruto
Refactor file: src/utils/parsers/index.js
a3b0935 
- consolidate all parsing logic into a static function: `ResponseParser.get`
- add some other strictly necessary changes to prevent circular imports:
  - extract utility function: `sanitizeFidFeature`
  - extract utility function: `reverseGeometry`
  - extract utility function: `removeZValueToOLFeatureGeometry`
  - extract utility function: `is3DGeometry`
  - extract utility function: `groupBy`
  - extract utility function: `addZValueToOLFeatureGeometry`
@Raruto Raruto added the refactoring Anything which could result in a API change label Jan 11, 2024
@Raruto Raruto added this to the v3.10 milestone Jan 11, 2024
@Raruto Raruto mentioned this pull request Feb 6, 2024
Merged
@volterra79 volterra79 marked this pull request as draft February 7, 2024 16:02
@volterra79 volterra79 modified the milestones: v3.10, v3.11 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volterra79 volterra79 Awaiting requested review from volterra79

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
refactoring Anything which could result in a API change
Projects
None yet
Milestone
v3.11
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Raruto @volterra79