Go through all slugs and make them legal values.

Upgrade gallery3 module to version 23
gallery · Jan 29, 2010 · 98bcb95 · 98bcb95
1 parent 844d40a
commit 98bcb95
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/modules/gallery/helpers/gallery_installer.php b/modules/gallery/helpers/gallery_installer.php
@@ -450,7 +450,7 @@ static function upgrade($version) {
 
     // Update the graphics rules table so that the maximum height for resizes is 640 not 480.
     // Fixes ticket #671
-    if ( $version == 21) {
+    if ($version == 21) {
       $resize_rule = ORM::factory("graphics_rule")
         ->where("id", "=", "2")
         ->find();
@@ -463,6 +463,27 @@ static function upgrade($version) {
       }
       module::set_version("gallery", $version = 22);
     }
+
+    // Update slug values to be legal.  We should have done this in the 11->12 upgrader, but I was
+    // lazy.  Mea culpa!
+    if ($version == 22) {
+      foreach (db::build()
+               ->from("items")
+               ->select("id", "slug")
+               ->where(new Database_Expression("`slug` REGEXP '[^_A-Za-z0-9-]'"), "=", 1)
+               ->execute() as $row) {
+        $new_slug = item::convert_filename_to_slug($row->slug);
+        if (empty($new_slug)) {
+          $new_slug = rand();
+        }
+        db::build()
+          ->update("items")
+          ->set("slug", $new_slug)
+          ->where("id", "=", $row->id)
+          ->execute();
+      }
+      module::set_version("gallery", $version = 23);
+    }
   }
 
   static function uninstall() {

diff --git a/modules/gallery/module.info b/modules/gallery/module.info
@@ -1,4 +1,4 @@
 name = "Gallery 3"
 description = "Gallery core application"
-version = 22
+version = 23