(mostly harmless) XSS fix in server add

gallery · Aug 31, 2009 · bd52a85 · bd52a85
1 parent fc294c2
commit bd52a85
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/modules/server_add/views/server_add_tree.html.php b/modules/server_add/views/server_add_tree.html.php
@@ -9,7 +9,7 @@
     <? foreach ($parents as $dir): ?>
     <li class="ui-icon-left">
       <span class="ui-icon ui-icon-folder-open"></span>
-      <span ondblclick="open_dir('<?= $dir ?>')">
+      <span ondblclick="open_dir(<?= html::js_string($dir) ?>)">
         <?= html::clean(basename($dir)) ?>
       </span>
       <ul>
@@ -22,7 +22,7 @@
                 <? if (is_dir($file)): ?>
                 ondblclick="open_dir($(this).attr('file'))"
                 <? endif ?>
-                file="<?= strtr($file, array('"' => '\\"')) ?>"
+                file="<?= html::clean_attribute($file) ?>"
                 >
             <?= html::clean(basename($file)) ?>
           </span>