Update package.json dependencies type #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you pleeeaaasssseee merge this |
|
This needs to be merged as many times build fails because of this. Please merge |
|
please merge |
|
@lihaiJett @vcgupta @bribrah if you still need it, I have pushed a fixed version of it https://www.npmjs.com/package/jsv-fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dependenciesfield of thepackage.jsonwas a type of array, butnpmspecifies it as an object type.This came up as I was trying to use
electron-builderand others saw a similar issue with other packages:electron-userland/electron-builder#3050