Typos found by codespell #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domainfun
reviewed
Oct 26, 2021
src/sandbox/common_gmvault.py
Outdated
| @@ -420,7 +420,7 @@ def get_operation_report(self): | |||
| Return the error report | |||
| """ | |||
| the_str = "\n================================================================\n"\ | |||
| "Number of reconnections: %d.\nNumber of emails quarantined: %d.\n" \ | |||
| "Number of reconnections: %d.\number of emails quarantined: %d.\n" \ | |||
There was a problem hiding this comment.
It's good to see typo fixes in this Pull Request, but this fix on line 423 may be incorrect? Perhaps the original line should be split into two lines for clarity, i.e. from:
"Number of reconnections: %d.\nNumber of emails quarantined: %d.\n" \
... to ...
"Number of reconnections: %d.\n" \
"Number of emails quarantined: %d.\n" \There was a problem hiding this comment.
Oh, I thought I had fixed this one. I'll have a look.
I had thought of splitting the line but wasn't certain you'd agree. If you do agree, i'll do that.
There was a problem hiding this comment.
Fixed, and split the lines - both for clarity and avoiding codespell false positives.
DimitriPapadopoulos
force-pushed
the
codespell
branch
from
37fe15f
to
14c90c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.