Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build with boost 1.85.0 #3386

Merged
merged 2 commits into from May 13, 2024
Merged

Fix build with boost 1.85.0 #3386

merged 2 commits into from May 13, 2024

Conversation

scpeters
Copy link
Member

馃 Bug fix

Fixes #3385.

Summary

The branch_path API was deprecated and has been removed in boost 1.85.0. This uses the recommended replacement method parent_path.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
Fix build with boost 1.85.0
6b4d0f0 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from traversaro as a code owner May 10, 2024 13:40
This was referenced May 10, 2024
Closed
Closed
Closed
@scpeters
Copy link
Member Author

this isn't quite enough; it's still failing

@scpeters
Copy link
Member Author

looks like basename and extension were deprecated / removed as well

/Users/scpeters/ws/gazebo/src/gazebo/gazebo/util/LogPlay.cc:417:29: error: no member named 'basename' in namespace 'boost::filesystem'
  return boost::filesystem::basename(this->dataPtr->filename) +
         ~~~~~~~~~~~~~~~~~~~^
/Users/scpeters/ws/gazebo/src/gazebo/gazebo/util/LogPlay.cc:418:24: error: no member named 'extension' in namespace 'boost::filesystem'
    boost::filesystem::extension(this->dataPtr->filename);
    ~~~~~~~~~~~~~~~~~~~^
2 errors generated.

https://github.com/boostorg/filesystem/blob/boost-1.84.0/include/boost/filesystem/convenience.hpp#L28-L38

@scpeters
Fix build error in LogPlay.cc as well
27c2277 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

looks like basename and extension were deprecated / removed as well

/Users/scpeters/ws/gazebo/src/gazebo/gazebo/util/LogPlay.cc:417:29: error: no member named 'basename' in namespace 'boost::filesystem'
  return boost::filesystem::basename(this->dataPtr->filename) +
         ~~~~~~~~~~~~~~~~~~~^
/Users/scpeters/ws/gazebo/src/gazebo/gazebo/util/LogPlay.cc:418:24: error: no member named 'extension' in namespace 'boost::filesystem'
    boost::filesystem::extension(this->dataPtr->filename);
    ~~~~~~~~~~~~~~~~~~~^
2 errors generated.

https://github.com/boostorg/filesystem/blob/boost-1.84.0/include/boost/filesystem/convenience.hpp#L28-L38

fix in 27c2277

@scpeters scpeters merged commit e4b4d0f into gazebo11 May 13, 2024
8 of 10 checks passed
@scpeters scpeters deleted the scpeters/boost_1_85 branch May 13, 2024 08:08
@scpeters scpeters mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gazebo11.14.0 fails to build against boost 1.85.0
2 participants
@scpeters @traversaro