Fix for French language using English day suffixes #16

mitchjacksontech · 2019-01-30T10:08:03Z

# Before: jan 30th 2019
# After:  jan 30e 2019
Date::Language->new('French')->time2str( "%b %o %Y", time() );

atoomic · 2020-01-13T18:02:12Z

lib/Date/Language/French.pm

@@ -32,5 +32,6 @@ sub format_b { $MoYs[$_[0]->[4]] }
 sub format_B { $MoY[$_[0]->[4]] }
 sub format_h { $MoYs[$_[0]->[4]] }
 sub format_p { $_[0]->[2] >= 12 ?  $AMPM[1] : $AMPM[0] }
+sub format_o { sprintf("%2de",$_[0]->[3]) }


a better French fix will be to do not use the suffix as it s not very common

The current suggested fix will be wrong in several cases
for example: 1st should be 1er,
then after ème is better than e for every other enumeration ....

Not being French myself, I defer to you and wikipedia, the better fix is do not use the suffix.

Will update the pull request accordingly

Fix for French language using English day suffixes

55bbe24

atoomic reviewed Jan 13, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for French language using English day suffixes #16

Fix for French language using English day suffixes #16

mitchjacksontech commented Jan 30, 2019

atoomic Jan 13, 2020 •

edited

mitchjacksontech Jan 14, 2020 •

edited

Fix for French language using English day suffixes #16

Are you sure you want to change the base?

Fix for French language using English day suffixes #16

Conversation

mitchjacksontech commented Jan 30, 2019

atoomic Jan 13, 2020 • edited

Choose a reason for hiding this comment

mitchjacksontech Jan 14, 2020 • edited

Choose a reason for hiding this comment

atoomic Jan 13, 2020 •

edited

mitchjacksontech Jan 14, 2020 •

edited