Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOS-11216] add graticule assembly to assemeby list so it is built #7475

Merged
merged 1 commit into from Mar 14, 2024

Conversation

ianturton
Copy link
Member

@ianturton ianturton commented Mar 14, 2024

GEOS-11216 Powered by Pull Request Badge

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

@ianturton ianturton requested a review from aaime March 14, 2024 14:57
@ianturton ianturton self-assigned this Mar 14, 2024
Copy link
Member

@aaime aaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, funny, I noticed just yesterday it was missing.

Looking at the "assembly" github action output:

2024-03-14T15:02:04.4955997Z 15:02:04,495 [INFO] Building zip: /home/runner/work/geoserver/geoserver/src/community/target/release/geoserver-2.26-SNAPSHOT-graticule-plugin.zip

Wondering, I see the assembly does not include gt-grid, it that because it's being provided by something else? I see WPS depending on it, but I don't see it being used in any other assembly file.

@ianturton
Copy link
Member Author

When run locally the zip file is correct, seems it just wasn't getting run if you don't say -Pgraticule

@ianturton ianturton merged commit 6a50ae8 into geoserver:main Mar 14, 2024
9 checks passed
@ianturton
Copy link
Member Author

Spoke too soon, gt-grid is missing from the zip, but something else is providing it. I'll add it in to make sure it is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants