New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEOS-11202] Respect proxy base URL when building CAS service URL. #7571
Conversation
...urity/cas/src/test/java/org/geoserver/security/cas/GeoServerCasAuthenticationFilterTest.java
Outdated
Show resolved
Hide resolved
2a8f5c4
to
60a5707
Compare
please run |
Run the URL through ResponseUtils.buildUrl to ensure it ultimately goes through ProxifyingURLManger.
I've now run |
Closing, reopening to trigger checks again |
The PR was merged with many failing builds: Now, the failure is due to API changes that are unrelated:
Still, this failure might be masking some other problem. Next time please rebase onto main and have the checks run once more. |
I don't understand, sorry. Minutes ago, there were only 10 (or 9?) checks, and they had all passed (after reopening the issue). I don't know why it shows 10/19 checks passed now. |
You're right, it's odd... it's as if it merged two subsequent runs in one report... |
The service URL built by the CAS extension now respects the proxy base URL (both the system property and the config value). I accomplished this by running the URL through ResponseUtils.buildUrl to ensure it ultimately goes through ProxifyingURLManger.
Furthermore, it also preserves the end-user's path and query parameters. This is to ensure that by the time the user is redirect back to the application from CAS, they will land on the original page they were trying to hit.
Checklist
main
branch (backports managed later; ignore for branch specific issues).For core and extension modules:
[GEOS-XYZWV] Title of the Jira ticket
.