Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOS-11332] Renaming style with uppercase/downcase empty the sld file #7580

Merged
merged 1 commit into from May 15, 2024

Conversation

aaime
Copy link
Member

@aaime aaime commented Apr 25, 2024

GEOS-11332 Powered by Pull Request Badge

Nasty little bug that causes "data loss" (as in, stylesheet loss)

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

@aaime
Copy link
Member Author

aaime commented Apr 29, 2024

@jodygarnett do you have 5 minutes for a review? It's loosely in Resource area, while it does not change it directly, the method is being used by it to handle renames. The original code was written with case-insensitive file systems in mind, and causes data loss on Linux (style body is lost, at least from the UI, takes a little digging into the data dir to recover it).

Copy link
Member

@jodygarnett jodygarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow the is a challenge, there is no way I know in java to detect if a file system is case sensitive.

@jodygarnett jodygarnett added backport 2.24.x Instructs the bot to create a 2.24.x backport PR on merge backport 2.25.x labels May 15, 2024
@jodygarnett jodygarnett assigned jodygarnett and aaime and unassigned jodygarnett May 15, 2024
@jodygarnett jodygarnett merged commit fb8e233 into geoserver:main May 15, 2024
11 checks passed
@aaime
Copy link
Member Author

aaime commented May 15, 2024

Yes, neither do I. But Files.move should figure it out by itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.24.x Instructs the bot to create a 2.24.x backport PR on merge backport 2.25.x
Projects
None yet
2 participants