Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOS-11407] Upgrade jackson from 2.15.2 to 2.17.1 #7664

Merged
merged 1 commit into from
May 21, 2024

Conversation

sikeoka
Copy link
Contributor

@sikeoka sikeoka commented May 20, 2024

GEOS-11407 Powered by Pull Request Badge

This PR is just a regular dependency upgrade.

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

@jodygarnett
Copy link
Member

Error: 5,756 [ERROR] /home/runner/work/geoserver/geoserver/src/community/smart-data-loader/src/main/java/org/geoserver/smartdataloader/data/SmartDataLoaderDataAccessFactory.java:[205,74] incompatible types: org.geotools.data.complex.config.DataAccessMap cannot be converted to boolean

Is this related to Jackson change?

@petersmythe
Copy link
Contributor

Is this related to Jackson change?

I do not think so, I have seen this error message over the last few PRs, and I was wondering how to fix it.

@sikeoka
Copy link
Contributor Author

sikeoka commented May 20, 2024

It appears to be caused by an API change in geotools/geotools#4730 and is fixed by #7633

@petersmythe petersmythe reopened this May 20, 2024
@petersmythe
Copy link
Contributor

Triggering checks again

@sikeoka
Copy link
Contributor Author

sikeoka commented May 20, 2024

That other PR needs to be merged and any PR that needs to run the build again will have to rebase or merge first.

@aaime
Copy link
Member

aaime commented May 21, 2024

Build restored, I believe this PR needs to be rebased

@jodygarnett jodygarnett added backport 2.24.x Instructs the bot to create a 2.24.x backport PR on merge backport 2.25.x labels May 21, 2024
@jodygarnett jodygarnett self-requested a review May 21, 2024 20:12
Copy link
Member

@jodygarnett jodygarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is needed to match GeoTools update.

In the future can we get away with a transitive dependency from GeoTools?

<jackson2.version>2.15.2</jackson2.version>
<jackson2.databind.version>2.15.2</jackson2.databind.version>
<jackson2.version>2.17.1</jackson2.version>
<jackson2.databind.version>${jackson2.version}</jackson2.databind.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed or can we getaway with transitive dependency from GeoTools?

Copy link
Contributor Author

@sikeoka sikeoka May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declaring these dependencies might help protect against dependabot doing things that, over time, may make GeoServer and GeoWebCache dependency management messier than it already is.

@jodygarnett jodygarnett merged commit 6143462 into geoserver:main May 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.24.x Instructs the bot to create a 2.24.x backport PR on merge backport 2.25.x
Projects
None yet
4 participants