-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEOS-11407] Upgrade jackson from 2.15.2 to 2.17.1 #7664
Conversation
Is this related to Jackson change? |
I do not think so, I have seen this error message over the last few PRs, and I was wondering how to fix it. |
It appears to be caused by an API change in geotools/geotools#4730 and is fixed by #7633 |
Triggering checks again |
That other PR needs to be merged and any PR that needs to run the build again will have to rebase or merge first. |
Build restored, I believe this PR needs to be rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is needed to match GeoTools update.
In the future can we get away with a transitive dependency from GeoTools?
<jackson2.version>2.15.2</jackson2.version> | ||
<jackson2.databind.version>2.15.2</jackson2.databind.version> | ||
<jackson2.version>2.17.1</jackson2.version> | ||
<jackson2.databind.version>${jackson2.version}</jackson2.databind.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed or can we getaway with transitive dependency from GeoTools?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declaring these dependencies might help protect against dependabot doing things that, over time, may make GeoServer and GeoWebCache dependency management messier than it already is.
This PR is just a regular dependency upgrade.
Checklist
main
branch (backports managed later; ignore for branch specific issues).For core and extension modules:
[GEOS-XYZWV] Title of the Jira ticket
.