Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel search: abort previous requests #6420

Draft
wants to merge 2 commits into
base: develop-minor
Choose a base branch
from

Conversation

distantnative
Copy link
Member

This PR …

Fixes

For review team

  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Apr 28, 2024
@distantnative distantnative added this to the 4.3.0 milestone Apr 28, 2024
@distantnative distantnative self-assigned this Apr 28, 2024
@distantnative distantnative force-pushed the fix/search-abort-controller branch 2 times, most recently from cb8223b to 87b30ab Compare April 28, 2024 17:33
@bastianallgeier
Copy link
Member

There are now quite a few situations where the search is showing "No results" while there's still a search going on in the background that will eventually deliver results. It feels a bit confusing.

@distantnative
Copy link
Member Author

@bastianallgeier tricky one. I think we cannot work with the current boolean isLoading then but rather need a counter incrementing when a request starts, decrementing when one is finished/aborted. What do you think?

@distantnative distantnative added the needs: changes 🔁 Implement any requested changes to proceed label Apr 30, 2024
@bastianallgeier
Copy link
Member

Yep, makes sense. I also saw yesterday that we need to improve the "no results" part. It should only be shown if nothing is loading and maybe show a "Searching …" placeholder instead if there are no results in the list but loading is still happening.

@distantnative distantnative marked this pull request as draft May 11, 2024 11:21
@distantnative distantnative removed this from the 4.3.0 milestone May 11, 2024
@distantnative
Copy link
Member Author

@bastianallgeier I tried to change it, but I am missing something, it still happens for me. Mostly when deleting parts of the query with backspace.

@distantnative distantnative added the needs: help 🙏 Really needs some help on this label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: changes 🔁 Implement any requested changes to proceed needs: help 🙏 Really needs some help on this type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search in panel shows old results when response times from server vary
2 participants