-
Notifications
You must be signed in to change notification settings - Fork 846
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[core] Ensure all lock guards are properly nested.
The lock analyzers in the `wgpu_core::lock` module can be a bit simpler if they can assume that locks are acquired and released in a stack-like order: that a guard is only dropped when it is the most recently acquired lock guard still held. So: - Change `Device::maintain` to take a `RwLockReadGuard` for the device's hal fence, rather than just a reference to it. - Adjust the order in which guards are dropped in `Device::maintain` and `Queue::submit`. Fixes #5610.
- Loading branch information
1 parent
7c842a3
commit 4a07ab2
Showing
3 changed files
with
21 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters