Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tweak setupColumnSort() to fix exception when col no longer exists #1477

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

ghiscoding
Copy link
Owner

  • this follows original SlickGrid PR 1016 to address a bug found in that repo

Copy link

stackblitz bot commented Apr 25, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (97da209) to head (9b968a4).

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1477     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         199     199             
  Lines       21715   21717      +2     
  Branches     7255    7256      +1     
========================================
+ Hits        21651   21653      +2     
- Misses         58      64      +6     
+ Partials        6       0      -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 094d760 into master Apr 25, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/sort-hidden-column branch April 25, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants