Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic basepath support #739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Basic basepath support #739

wants to merge 1 commit into from

Conversation

rpeyron
Copy link

@rpeyron rpeyron commented Oct 20, 2022

A very simple PR to add support for a basepath of the website, to be removed from pathname before searching/creating GitHub discussion. It adds a data-base-path parameter.

For a jekyll site, it can be simply set to site.baseurl:

       data-base-path="{{ site.baseurl }}"

For development purpose, I have also added the ability to override giscusOrigin to be able to use a custom client.js with the giscus server. I guess this could be useful to other contributors.

@vercel
Copy link

vercel bot commented Oct 20, 2022

@rpeyron is attempting to deploy a commit to the giscus Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant