Fix RT #81381 - Make LWP::UserAgent robust to 5.17.6/5.18 hash randomization #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ization
Audited and fixed any potential hash order dependency bugs in
LWP::UserAgent. I replaced all the uses of each() with keys() to avoid
hash iterator state bugs, and made sure that keys are sorted where
their order might matter, which was as far as I could tell only in
how proxy configuration was read from the envrionment.
There was ambiguity as to which of $ENV{http_proxy} and
$ENV{HTTP_PROXY} would be chosen by LWP::UserAgent->env_proxy(). We now
choose HTTP_PROXY if both are set, and if they differ we warn about
the conflicting configuration.
This patch includes tests to check that we warn on conflicting config
and that we correctly handle setting via either.
This includes a version bump to 6.05.
See also:
libwww-perl RT Ticket
https://rt.cpan.org/Ticket/Display.html?id=81381
bleadperl 5.17.6 patch (queued for 5.18):
http://perl5.git.perl.org/perl.git/commit/7dc8663964c66a698d31bbdc8e8abed69bddeec3
Eliminating the "rehash" mechanism for 5.18
http://www.nntp.perl.org/group/perl.perl5.porters/2012/10/msg194813.html
Switch perl's hash function to MurmurHash-32 (v3) and hash randomization by default.
http://www.nntp.perl.org/group/perl.perl5.porters/2012/11/msg195492.html
This was referenced Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audited and fixed any potential hash order dependency bugs in
LWP::UserAgent. I replaced all the uses of each() with keys() to avoid
hash iterator state bugs, and made sure that keys are sorted where
their order might matter, which was as far as I could tell only in
how proxy configuration was read from the envrionment.
There was ambiguity as to which of $ENV{http_proxy} and
$ENV{HTTP_PROXY} would be chosen by LWP::UserAgent->env_proxy(). We now
choose HTTP_PROXY if both are set, and if they differ we warn about
the conflicting configuration.
This patch includes tests to check that we warn on conflicting config
and that we correctly handle setting via either.
This includes a version bump to 6.05.
See also:
libwww-perl RT Ticket
https://rt.cpan.org/Ticket/Display.html?id=81381
bleadperl 5.17.6 patch (queued for 5.18):
http://perl5.git.perl.org/perl.git/commit/7dc8663964c66a698d31bbdc8e8abed69bddeec3
Eliminating the "rehash" mechanism for 5.18
http://www.nntp.perl.org/group/perl.perl5.porters/2012/10/msg194813.html
Switch perl's hash function to MurmurHash-32 (v3) and hash randomization by default.
http://www.nntp.perl.org/group/perl.perl5.porters/2012/11/msg195492.html