gitcfg: properly handle mixed-case names in find()

We downcase the search pattern to match the case-ignoring behavior used
by "git config", but we did not also downcase the candidate string.

Downcase both so that we properly support having tool with mixed case
names.  Add a test to ensure the proper behavior.

Related-to: #44
Reported-by: Leho Kraav <leho@kraav.com>
Signed-off-by: David Aguilar <davvid@gmail.com>

cola/gitcfg.py

@@ -301,7 +301,7 @@ def find(self, pat):
         result = {}
         self.update()
         for key, val in self._all.items():
-            if match(key, pat):
+            if match(key.lower(), pat):
                 result[key] = val
         return result
 

share/doc/git-cola/relnotes.rst

@@ -15,6 +15,8 @@ Fixes
 * The `Ctrl+P` hotkey was overloaded to both "push" and "cherry-pick",
   so "cherry-pick" was moved to `Shift+Ctrl+C`.
 
+* Custom GUI tools with mixed-case names are now properly supported.
+
 git-cola v2.0.4
 ===============
 Usability, bells and whistles

test/gitcfg_test.py

@@ -66,6 +66,14 @@ def test_guitool_names(self):
         names = self.config.get_guitool_names()
         self.assertTrue('hello meow' in names)
 
+    def test_guitool_names_mixed_case(self):
+        self.shell('git config guitool."Meow Cat".cmd "cat hello"')
+        names = self.config.get_guitool_names()
+        self.assertTrue('Meow Cat' in names)
+
+        opts = self.config.find('guitool.Meow Cat.*')
+        self.assertEqual(opts['guitool.Meow Cat.cmd'], 'cat hello')
+
 
 if __name__ == '__main__':
     unittest.main()