Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #577 i18n support #1937

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

airaketa
Copy link

Description

Closes #577
Implemented i18n using vscode-nls and vscode-nls-dev

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@airaketa airaketa changed the title Feature: i18n support Closes #577 i18n support Mar 29, 2022
@airaketa
Copy link
Author

airaketa commented Apr 1, 2022

@eamodio can you take a look at this? Ready to make edits to get it merged asap

@eamodio
Copy link
Member

eamodio commented Apr 13, 2022

@airaketa Wow! This is awesome! It will definitely take me some time to review all of the changes.

I did notice that some strings were changed, though -- could I ask you to check to ensure that no strings have changed in this process, unless there is a specific reason to change one.

@airaketa
Copy link
Author

airaketa commented Apr 13, 2022

@eamodio One of the reasons that I changed some strings was that in some languages word's suffix depends on its context in a sentence.

Also I had to remove pluralize function calls because some languages have 3 plural forms instead of 2 like it is in English (e.g. slavic languages where you have different word suffix for amount of 1, 2-4 and >4 accordingly).
In this case I preserved 2 plural forms like it is in English to keep code as simple as possible, but the whole sentence substitution allows localizators to change word order to make it sound authentic in the target language.
E.g. one can write:

  1. ветка впереди на 1 коммит (branch is 1 commit ahead)
  2. ветка впереди на несколько ({0}) коммитов (branch is several ({0}) commits ahead)

Instead of 3 forms:

  1. ветка впереди на 1 коммит (branch is 1 commit ahead)
  2. ветка впереди на 3 коммита (branch is 3 commits ahead)
  3. ветка впереди на 5 коммитов (branch is 5 commits ahead)

In other words, the idea was to replace "composite" strings, which are assembled from different combinations of words and their forms, with completed sentences so that localizators could decide which form should one or another word have depending on the context.
I believe this answer can help to understand these principles better: https://stackoverflow.com/a/390247

So there should be no difference for English-speaking users, feel free to tell if there is one. I will also try to fix such issues if I notice them.

@airaketa airaketa force-pushed the feature/i18n branch 2 times, most recently from 5568f2e to aaea180 Compare April 29, 2022 17:10
@airaketa airaketa force-pushed the feature/i18n branch 2 times, most recently from dcbd1ed to 562e2a4 Compare July 19, 2022 16:55
@airaketa
Copy link
Author

@eamodio, Hi, is there any update?
Perhaps it would be more convenient to check the pull request in small batches of files at a time since it is huge.

@Cyberhan123
Copy link

Is there anything new and can I help

@airaketa airaketa force-pushed the feature/i18n branch 2 times, most recently from 8ff0d1f to bc54d79 Compare October 15, 2022 11:58
@zhang-wenchao
Copy link

@eamodio Is there any progress in this?

@zhang-wenchao
Copy link

@eamodio Please try to pay attention to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HELP WANTED: Add internationalization (i18n) support to GitLens
4 participants