New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #577 i18n support #1937
base: main
Are you sure you want to change the base?
Closes #577 i18n support #1937
Conversation
@eamodio can you take a look at this? Ready to make edits to get it merged asap |
@airaketa Wow! This is awesome! It will definitely take me some time to review all of the changes. I did notice that some strings were changed, though -- could I ask you to check to ensure that no strings have changed in this process, unless there is a specific reason to change one. |
@eamodio One of the reasons that I changed some strings was that in some languages word's suffix depends on its context in a sentence. Also I had to remove
Instead of 3 forms:
In other words, the idea was to replace "composite" strings, which are assembled from different combinations of words and their forms, with completed sentences so that localizators could decide which form should one or another word have depending on the context. So there should be no difference for English-speaking users, feel free to tell if there is one. I will also try to fix such issues if I notice them. |
5568f2e
to
aaea180
Compare
dcbd1ed
to
562e2a4
Compare
@eamodio, Hi, is there any update? |
7d946bf
to
3a372e4
Compare
Is there anything new and can I help |
8ff0d1f
to
bc54d79
Compare
bc54d79
to
d2f11c2
Compare
@eamodio Is there any progress in this? |
@eamodio Please try to pay attention to this issue. |
Description
Closes #577
Implemented i18n using vscode-nls and vscode-nls-dev
Checklist
Fixes $XXX -
orCloses #XXX -
prefix to auto-close the issue that your PR addresses