Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #614 - remote URL not working for wiki links #2220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeffslofish
Copy link

Description

Fixes #614 - remote URL not working for wiki links

This only fixes the remote URL for GitHub wikis. If there are additional providers that use wikis that we want to support then those will need to be added.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@eamodio
Copy link
Member

eamodio commented Nov 3, 2022

@jeffslofish Thanks for this, but unfortunately there seems to be a lot more needed than just converting .wiki to /wiki -- in my quick testing, revision URLs need to be reformatted form .wiki/blob/<sha>/<wiki-file-name>.md to /wiki/<wiki-file-name>/<sha>. There also doesn't seem to be a URL to get to a wiki commit, branch, etc.

@eamodio eamodio self-requested a review November 3, 2022 03:41
Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See main comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remote URL not working for wiki links
2 participants