Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1651 - search & compare opens file instead of diff #2845

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Svaught598
Copy link

Description

Closes #1651. Instead of opening a diff from the Search & Compare view, this opens the current revision's file.

The use case seems to be setting a up the workspace, so line numbers seem to be inconsequential here. Can definitely put that back in if it's needed.

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@eamodio eamodio self-requested a review August 5, 2023 20:01
Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Svaught598 Thanks for the contribution, but this would need to be on a setting new setting, e.g. gitlens.views.<view-name>.files.openDiffOnClick which would default to true. Also we should definitely keep jumping to the line number of the first diff hunk.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow opening file instead of diff
2 participants