Fixes #3090 and #2575 - Treats .git/gitdir as cwd on "empty" bare clones #3092
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwangh95
force-pushed
the
fix-empty-bare-clone-parsing
branch
from
5df0c1b
to
8a0a323
Compare
hwangh95
force-pushed
the
fix-empty-bare-clone-parsing
branch
2 times, most recently
from
fa54bdf
to
fc0ffd4
Compare
|
@eamodio Hello, could you please have a look at this PR? |
…n "empty" bare clones There are cases for having bare clones with multiple worktrees in the same folder to manage various versions in a workspace Currently, however, the only supported way to do this is to have the .git/ files such as HEAD, branches/, refs/, worktrees/, etc in the same folder as your actual worktrees. This makes your workspace very cluttered and is counterproductive to the structured way of multiple worktrees What many of us prefer is to have an "empty" bare clone with the normal bare clone files within the .git/ folder or another folder labeled .bare and use a .git file with a gitdir reference This fix will allow for the worktrees view to function the same way it would show on a `git worktree list` command
hwangh95
force-pushed
the
fix-empty-bare-clone-parsing
branch
from
fc0ffd4
to
5ab5ff8
Compare
|
@d13 Hey sorry for the ping but could you look at this PR? Or is there someone else who can? I've been waiting for feedback for about a month now |
|
@d13 Still waiting for feedback on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are cases for having bare clones with multiple worktrees in the same folder to manage various versions in a workspace
Currently, however, the only supported way to do this is to have the .git/ files such as HEAD, branches/, refs/, worktrees/, etc in the same folder as your actual worktrees. This makes your workspace very cluttered and is counterproductive to the structured way of multiple worktrees
What many of us prefer is to have an "empty" bare clone with the normal bare clone files within the .git/ folder or another folder labeled .bare and use a .git file with a gitdir reference
This fix will allow for the worktrees view to function the same way it would show on a
git worktree listcommandChecklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses