Fix Alt+[0-9] behaviour to respect order of merged buffers #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzhs
commented
Nov 10, 2016
| @@ -359,8 +360,7 @@ weechat.directive('inputBar', function() { | |||
|
|
|||
| // Alt-h -> Toggle all as read | |||
| if ($event.altKey && !$event.ctrlKey && code === 72) { | |||
| var buffers = models.getBuffers(); | |||
| _.each(buffers, function(buffer) { | |||
| _.each(models.getBuffers(), function(buffer) { | |||
There was a problem hiding this comment.
It's kind of ridiculous to fix jshint by getting rid of this binding but honestly I find this solution preferable to renaming buffers above. Or maybe pull it up to the beginning of the function?
lorenzhs
changed the title
lorenzhs
changed the title
|
Marked WIP because it doesn't seem to handle filtered buffers correctly Edit: Can't really reproduce, filtered buffers work just fine? And "show only unread" doesn't affect quick keys so it shouldn't affect this either imho |
lorenzhs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been bugging me for a long time. When connecting to more networks, the newest ones will be first in the buffers object, so alt+1 will go there. But it should go to core.weechat. Fix this by adding the index as sort criterion.
This matches the
getBufferQuickKeys()behaviour.