Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change action GETs to POST #10462

Merged
merged 8 commits into from Feb 25, 2020
Merged

Change action GETs to POST #10462

merged 8 commits into from Feb 25, 2020

Conversation

jolheiser
Copy link
Member

No description provided.

jolheiser and others added 7 commits February 24, 2020 20:54
@jolheiser
Change action GETs to POST
1068c07 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser @guillep2k
submite = submit + smite
196d285 
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
@jolheiser
No more # href
da31ce4 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser
Fix test
681534d 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser
Match other tests
6c1a19b 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser
Merge branch 'master' of https://github.com/go-gitea/gitea into jolhe…
8a7fbed 
…iser-fix-get
@jolheiser
Merge branch 'master' of https://github.com/go-gitea/gitea into jolhe…
89810f5 
…iser-fix-get
@jolheiser jolheiser added this to the 1.12.0 milestone Feb 25, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 25, 2020
@jolheiser
Explicit csrf
6882cad 
Signed-off-by: jolheiser <john.olheiser@gmail.com>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 25, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@8a7fbed). Click here to learn what that means.
The diff coverage is 59.09%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10462   +/-   ##
=========================================
  Coverage          ?    43.7%           
=========================================
  Files             ?      586           
  Lines             ?    81411           
  Branches          ?        0           
=========================================
  Hits              ?    35579           
  Misses            ?    41428           
  Partials          ?     4404
Impacted Files Coverage Δ
routers/api/v1/repo/tag.go 86.58% <100%> (ø)
modules/git/repo_tag.go 57.57% <18.18%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a7fbed...6882cad. Read the comment docs.

@jolheiser jolheiser merged commit c161bb0 into go-gitea:master Feb 25, 2020
jolheiser added a commit to jolheiser/gitea that referenced this pull request Feb 25, 2020
@jolheiser @guillep2k
Change action GETs to POST (go-gitea#10462)
03cec5a 
* Change action GETs to POST

* submite = submit + smite

* No more # href

* Fix test

* Match other tests

* Explicit csrf

Signed-off-by: jolheiser <john.olheiser@gmail.com>

Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
@jolheiser jolheiser mentioned this pull request Feb 25, 2020
Merged
@jolheiser jolheiser added the backport/done All backports for this PR have been created label Feb 25, 2020
@jolheiser jolheiser deleted the jolheiser-fix-get branch February 25, 2020 20:45
jolheiser added a commit that referenced this pull request Feb 25, 2020
@jolheiser @guillep2k
Change action GETs to POST (#10462) (#10464)
4cb1860 
* Change action GETs to POST

* submite = submit + smite

* No more # href

* Fix test

* Match other tests

* Explicit csrf

Signed-off-by: jolheiser <john.olheiser@gmail.com>

Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
@zeripath zeripath mentioned this pull request Feb 27, 2020
Closed
7 tasks
This was referenced Mar 2, 2020
Closed
Closed
@zeripath zeripath added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Mar 6, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jolheiser @codecov-io @techknowlogick @guillep2k @zeripath @GiteaBot