Environment definitions in task files should have precedence over predefined environment variables #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 馃憢
I have tried to add a test + a fix for the (potential) bug #1038.
Environment variable definitions within a task file take precedence over environment variables defined in shell.
backwards compatibility
Changes may have problems about backwards compatibility:
Despite no test are failing nor any documentation guaranteed that behavior, it may have an impact.
I would like to discuss that.
Tasks
task_test.go)Testing
In order to test that behavior, it was mandatory to compile / run the task binary itself.
As an explicit and repeatable control over the outside environment configuration is mandatory, I think following that path is the only path that leads to real feedback.