Fix flaky test TestStartupTimeout #1558
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In conn_test.go, TestStartupTimeout at the very last step requires the log to contain "no response to connection startup within timeout". However, during my test, it fails sometimes with log containing "no response received from cassandra within timeout period" instead. Fixing the flaky test by allowing log to contain either message.
|
Hello. Thank you for the pull request! The change looks good to me. Could you please add yourself to AUTHORS file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conn_test.go, "TestStartupTimeout" at the very last step requires the log to contain "no response to connection startup within timeout".
However, during my test, it fails sometimes, not always, with log containing "no response received from cassandra within timeout period" instead.
Fixing the flaky test by allowing log to contain either message.