Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop exporting development files #871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented May 18, 2023

Exclude these files from GitHub ZIP-s and everywhere where those ZIP-s are linked.

Test: git archive HEAD | tar --list

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jul 18, 2023

@AnthonyLedesma Could you lend me a click here?

@AnthonyLedesma
Copy link
Member

@szepeviktor I am not convinced this is what we need for our workflow. We are integrated with GitHub actions right now, the specific workflow can be seen here:

gh release create $RELEASE_VERSION -n "${{ github.event.milestone.description }}" -t "$RELEASE_VERSION"

For that specific line, we are using the CLI from cli.github.com to package a release within the pipeline. When testing out our existing flow, with the new .gitattributes file, I get the same results as without the new file. Is possible that the command may need to be modified as well perhaps to pass in a config file, but I am not sure about that.

@EvanHerman Getting a look at what is packaged by this command:
Screenshot 2023-07-18 at 1 12 44 PM
There are some extra files like the config, readme, and lock file. Do you think we should consider changing this release command?

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jul 18, 2023

AFAIK gh release create does not package anything.
Releases may have attachments

  • "Source.tar.gz" with the very same content as the repo
  • And custom attachments

This PR is for GitHub ZIP-s used by Packagist (Composer's repo) and NPM.

image

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jul 18, 2023

When that custom attachment (artifact) is created rsync --include-from=.distinclude a custom list of included files is read, totally unrelated to git.

That artifact is built, thus contains downloaded and generated files.
This PR is related to git, so the development version.
Try git archive HEAD | tar --list with and without this PR. (.gitattributes needs to be committed)

You may ask: Does anyone use Go's development version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants