Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add site url checker #44

Merged

Conversation

AntoineKM
Copy link
Contributor

@AntoineKM AntoineKM commented Mar 18, 2024

What did I change?

Before running the rest of the script, we check that the user has access to the requested site, and if he's made a mistake, we correct the URL.

Why did I change it?

Many users make a mistake, or encounter an error related to this when it's just a matter of understanding, so we needed a solution to fix this problem automatically. (close: #37)

@AntoineKM AntoineKM marked this pull request as ready for review March 18, 2024 15:50
@AntoineKM AntoineKM changed the title add site url checker (#37) add site url checker Mar 18, 2024
@AntoineKM
Copy link
Contributor Author

Enregistrement.de.l.ecran.2024-03-18.a.17.07.46.mov

src/shared/gsc.ts Outdated Show resolved Hide resolved
@goenning
Copy link
Owner

that was fast! We could probably simplify the readme a bit and just tell the user to use gis domain.com as the script will figure out which format to use

@AntoineKM AntoineKM force-pushed the antoinekm/recheck-opposite-property branch from 7dd3a09 to ecc9db5 Compare March 19, 2024 09:15
@AntoineKM
Copy link
Contributor Author

Yes, it should be better now 😁

@goenning goenning merged commit 8598813 into goenning:main Mar 19, 2024
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hey does this script support subdomains?
2 participants