fix protoc output parsing bug #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,7 +60,7 @@ func parseFile(filename string, includeSourceInfo bool, includeImports bool, pat | |||
| args = append(args, filename) | |||
| cmd := exec.Command("protoc", args...) | |||
| cmd.Env = []string{} | |||
| data, err := cmd.CombinedOutput() | |||
| data, err := cmd.Output() | |||
| if err != nil { | |||
| return nil, &errCmd{data, err} | |||
There was a problem hiding this comment.
Unfortunately the fix is a little more complicated than that.
The data returned in the error command now doesn't include the stderr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parseFile function execute a protoc process to retrieve the message descriptor from a file and then parse from the output of the process, but it makes use of the CombinedOutput method of the Cmd struct, which combined both the stdout and stderr of the process, leading to imparseable string when the protoc process emits warnings on stderr.
I just replaced the call to CombinedOutput but a call to Output, which only returns stdout.