Copy only the static files changed #1671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the flag forceCopyStatic to always copy all static files when a file is changed
|
|
ffrizzo
changed the title
|
Thank you for your contribution, @ffrizzo! But before we continue, could you please read the Code Contribution Guideline and make the appropriate changes? (e.g. the git commit message). Many thanks! |
Update on the watcher copy static to copy only the changed files and add an flag forceSyncStatic to copy all statics always a static is changed See gohugoio#1644 gohugoio#1559
ffrizzo
changed the title
| @@ -171,7 +172,7 @@ func initCoreCommonFlags(cmd *cobra.Command) { | |||
| cmd.Flags().BoolVar(&nitro.AnalysisOn, "stepAnalysis", false, "display memory and timing of different steps of the program") | |||
| cmd.Flags().BoolVar(&PluralizeListTitles, "pluralizeListTitles", true, "Pluralize titles in lists using inflect") | |||
| cmd.Flags().BoolVar(&PreserveTaxonomyNames, "preserveTaxonomyNames", false, `Preserve taxonomy names as written ("Gérard Depardieu" vs "gerard-depardieu")`) | |||
|
|
|||
| cmd.Flags().BoolVarP(&ForceSync, "forceSyncStatic", "", true, "Copy all files when static is changed.") | |||
There was a problem hiding this comment.
I think this should be default false
Update on the watcher copy static to copy only the changed files and add an flag forceSyncStatic to copy all statics always a static is changed See gohugoio#1644 gohugoio#1559
| syncer.SrcFs = hugofs.SourceFs | ||
| syncer.DestFs = hugofs.DestinationFS | ||
|
|
||
| publishDir := helpers.AbsPathify(viper.GetString("PublishDir")) + "/" |
Update on the watcher copy static to copy only the changed files and add an flag forceSyncStatic to copy all statics always a static is changed See gohugoio#1644 gohugoio#1559
|
@bep This now looks good to me. Are you okay with me merging? |
|
Sure. |
|
Merged as a291f3c |
Closed
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update on the watcher copy static to copy only the changed files and add an flag forceSyncStatic to copy all statics always a static is changed
#1644 #1559