Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated golint #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
31 changes: 13 additions & 18 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,13 @@ goreportcard-cli
```

```
Grade .......... A+ 99.9%
Files ................ 362
Issues ................. 2
Grade ........... A+ 98.1%
Files ................ 962
Issues ............... 158
gofmt ............... 100%
go_vet ............... 99%
gocyclo .............. 99%
golint .............. 100%
go_vet .............. 100%
ineffassign ......... 100%
gocyclo .............. 83%
license ............. 100%
misspell ............ 100%
```
Expand All @@ -75,20 +74,16 @@ goreportcard-cli -v
```

```
Grade .......... A+ 99.9%
Files ................ 362
Issues ................. 2
Grade ........... A+ 98.1%
Files ................ 962
Issues ............... 158
gofmt ............... 100%
go_vet ............... 99%
go_vet vendor/github.com/prometheus/client_golang/prometheus/desc.go:25
error: cannot find package "github.com/prometheus/client_model/go" in any of: (vet)

gocyclo .............. 99%
gocyclo download/download.go:22
warning: cyclomatic complexity 17 of function download() is high (> 15) (gocyclo)

golint .............. 100%
go_vet .............. 100%
ineffassign ......... 100%
gocyclo .............. 83%
vendor/honnef.co/go/tools/staticcheck/structtag.go
Line 8: warning: cyclomatic complexity 19 of function parseStructTag() is high (> 15) (gocyclo)

license ............. 100%
misspell ............ 100%
```
Expand Down
1 change: 0 additions & 1 deletion check/check.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ func Run(dir string, cli bool) (ChecksResult, error) {
checks := []Check{
GoFmt{Dir: dir, Filenames: filenames},
GoVet{Dir: dir, Filenames: filenames},
// GoLint{Dir: dir, Filenames: filenames},
GoCyclo{Dir: dir, Filenames: filenames},
License{Dir: dir, Filenames: []string{}},
Misspell{Dir: dir, Filenames: filenames},
Expand Down
27 changes: 0 additions & 27 deletions check/golint.go

This file was deleted.

1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ require (
github.com/fzipp/gocyclo v0.3.1
github.com/gordonklaus/ineffassign v0.0.0-20210914165742-4cc7213b9bc8
github.com/prometheus/client_golang v1.14.0
golang.org/x/lint v0.0.0-20201208152925-83fdc39ff7b5
honnef.co/go/tools v0.1.3
)

Expand Down
2 changes: 0 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,6 @@ golang.org/x/lint v0.0.0-20190930215403-16217165b5de/go.mod h1:6SW0HCj/g11FgYtHl
golang.org/x/lint v0.0.0-20191125180803-fdd1cda4f05f/go.mod h1:5qLYkcX4OjUUV8bRuDixDT3tpyyb+LUpUlRWLxfhWrs=
golang.org/x/lint v0.0.0-20200130185559-910be7a94367/go.mod h1:3xt1FjdF8hUf6vQPIChWIBhFzV8gjjsPE/fR3IyQdNY=
golang.org/x/lint v0.0.0-20200302205851-738671d3881b/go.mod h1:3xt1FjdF8hUf6vQPIChWIBhFzV8gjjsPE/fR3IyQdNY=
golang.org/x/lint v0.0.0-20201208152925-83fdc39ff7b5 h1:2M3HP5CCK1Si9FQhwnzYhXdG6DXeebvUHFpre8QvbyI=
golang.org/x/lint v0.0.0-20201208152925-83fdc39ff7b5/go.mod h1:3xt1FjdF8hUf6vQPIChWIBhFzV8gjjsPE/fR3IyQdNY=
golang.org/x/mobile v0.0.0-20190312151609-d3739f865fa6/go.mod h1:z+o9i4GpDbdi3rU15maQ/Ox0txvL9dWGYEHz965HBQE=
golang.org/x/mobile v0.0.0-20190719004257-d2bd2a29d028/go.mod h1:E/iHnbuqvinMTCcRqshq8CkpyQDoeVncDDYHnLhea+o=
golang.org/x/mod v0.0.0-20190513183733-4bf6d317e70e/go.mod h1:mXi4GBBbnImb6dmsKGUJ2LatrhH/nqhxcFungHvyanc=
Expand Down
1 change: 0 additions & 1 deletion scripts/make-install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

go install ./vendor/github.com/alecthomas/gometalinter

go install ./vendor/golang.org/x/lint/golint
go install ./vendor/github.com/fzipp/gocyclo/cmd/gocyclo
go install ./vendor/github.com/gordonklaus/ineffassign
go install ./vendor/github.com/client9/misspell/cmd/misspell
1 change: 0 additions & 1 deletion tools/tools.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@ import (
_ "github.com/client9/misspell/cmd/misspell"
_ "github.com/fzipp/gocyclo/cmd/gocyclo"
_ "github.com/gordonklaus/ineffassign"
_ "golang.org/x/lint/golint"
_ "honnef.co/go/tools/cmd/staticcheck"
)
19 changes: 0 additions & 19 deletions vendor/golang.org/x/lint/.travis.yml

This file was deleted.

15 changes: 0 additions & 15 deletions vendor/golang.org/x/lint/CONTRIBUTING.md

This file was deleted.

27 changes: 0 additions & 27 deletions vendor/golang.org/x/lint/LICENSE

This file was deleted.

89 changes: 0 additions & 89 deletions vendor/golang.org/x/lint/README.md

This file was deleted.